Repository navigation
tools(eval): nav.audit split into nav.warm/tile/label; tasks of 100 ms or more attributed to a cause (#2592 follow-up) - #2604
Merged
Conversation
…ach task of 100 ms or more gets a cause (#2592) The profile classifier's nav.audit mixed the budgeted connectivity audit, fine tiles built on demand and labels built on demand. They are now three groups that still sum to the old one. Each JS task of 100 ms or more is attributed to a cause (for nav.*, the caller outside the spatial service; otherwise the frame just under the group's entry, followed down while one child holds half the task), with the top 10 per group and a compact list of the tasks and their heaviest paths, so later runs need no .cpuprofile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
genekogan
marked this pull request as ready for review
November 16, 2026 12:31
Contributor
Proof check:
|
| Check | Status | Detail |
|---|---|---|
| problem statement | ok | present |
Acceptance criteria
| Criterion | Status | Evidence | |
|---|---|---|---|
| [x] | A1 A unit test with a synthetic profile: tasks land in the right new grou | met | node --test tools/playtest/eval/prof-buckets.test.mjs -> 5 pass, 0 fail. The new test checks five things. A tile built |
| [ ] | A2 Re-run the attribution offline on the existing artifacts (runs 4385886 | deferred | the artifacts lack the raw profile, because load.mjs deletes world.cpuprofile after bucketing it. What they do allow |
| [x] | A3 The artifact lacks the raw profile, as stated, so the instrument now k | met | step0.longTasks (each task of 100 ms or more: group, cause, top 3 groups, the heaviest path's app frames) and `step0.c |
Proof links: 0 video, 0 image, no proof.json.
Warnings
- Problem does not link an issue (Closes #n)
Updated on every edit, push, label and review. How to fill it: .claude/skills/journal/SKILL.md. T3-T4 also need the maintainer's sign-off (tools/proof/gate.mjs). A maintainer can waive with the proof:waived label.
genekogan
enabled auto-merge
November 16, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The profiler's grouping misled two lane A investigations (A9 and A11, issues 2592 and 2601). Its
nav.auditgroup mixed three things: the budgeted connectivity audit, fine tiles built on demand, and labels built on demand. Its "rest of the tick" (tick) group was not attributed at all. This dispatched follow-up has no issue of its own: the coordinator's brief sets its bounds, and this PR is the record.Acceptance
node --test tools/playtest/eval/prof-buckets.test.mjs-> 5 pass, 0 fail. The new test checks five things. A tile built under the audit goes to nav.warm, asked bynavStep. A tile from a walker's page sync goes to nav.tile, asked byenterLeg. A label-cache miss in an act's read goes to nav.label, asked bygoal, with the engine'snavCheckV1wrapper skipped. A tick with one dominant path is attributed tocrowd, the deepest frame holding at least 50 %. A tick with no dominant child is attributed tostepInner, the frame just under the tick. Tasks under 100 ms are left out, andnavAuditMsPerSecis the sum of the three groups.load.mjsdeletesworld.cpuprofileafter bucketing it. What they do allow (the longest nav runs sorted into the new groups, and the task counts) and the exact next run are posted at Scaling A9 · The world's clock thread holds the loop for seconds, so admission stays amber and acts starve #2592 (comment). The tables come from the next profiled run with this instrument.step0.longTasks(each task of 100 ms or more: group, cause, top 3 groups, the heaviest path's app frames) andstep0.causes(top 10 per group, with counts), asserted in the new test; issue comment Scaling A9 · The world's clock thread holds the loop for seconds, so admission stays amber and acts starve #2592 (comment)Proof
Tier: T0 (
node tools/proof/tier.mjs-> T0, tools and docs only)Self-audit
node --test tools/playtest/eval/prof-buckets.test.mjs-> 5 passnode .github/scripts/guards.mjs scrub --base origin/main-> 0 problemsnode tools/proof/publication.mjson the issue comment and on this body -> passed--profileruns are affected.load-result.jsongains about 0.5 KB per task of 100 ms or more (about 370 tasks at 50 agents, so roughly 200 KB). The world itself does not change.navAuditMsPerSec, and the line in load.mjs that prints it, keep their old meaning: the sum of the three groups.nav.*the cause is the caller (who asked), because the nav functions are leaf builders and their callee would name build internals. For the other groups it is the callee under the group's entry.nav.warmincludes the spatial sync thatnavWarmV1starts with, as the engine documents it ("including the current spatial sync"). This keeps the old group equal to the three new ones, sample for sample.causes/longTasks.Changelog
no-changelog: tools and docs only.Risk
Low. Measurement-only code in the eval tools. Group names change for
--profilereports, and the header maps old tables to new ones. Roll back by reverting this commit.Outside Touches: docs/architecture/load.md (3 lines changed: the group list, plus a sentence on causes).
Time: started 12:23 UTC. The PR opened at 12:32 UTC, about 9 minutes of the 1.5 h ceiling.
🤖 Generated with Claude Code