-
Notifications
You must be signed in to change notification settings - Fork 173
CSE Machine: Fix some UI & animations issues, and add tests #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sayomaki do you have time to review this? It's a pure FE change and the PR seems ready, I don't see a reason not to merge it if it's all good |
Update: to be merged by 29/9/2025, to be ready for Unit 3 of CS1101S. |
RichDom2185
approved these changes
Aug 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just the above comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some UI & animations issues, and add some tests for the CSE machine's layout and animations.

Fixes #2921 fully by correctly calculating the width of the frame with a rune.
Also see: #2959.Fixes #2716. The new result is shown below:
Changes
UI
:::pre-declared names:::
now should appear first, above all bindings_height
and_width
now only refer to the height and widths of the array boxes or closure circles onlyArrayValue
now has atotalHeight
andtotalWidth
property that stores the total height and width of nested values inside the arrayFnValue
andGlobalFnValue
has atotalWidth
property that also includes the tooltip widthAnimations
FrameCreationAnimation
BaseAnimationComponent
, so that the example below has the correct expected behavior:Testing
AnimationComponent