Skip to content

Feat/conflict popup #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lwray-renesas
Copy link
Contributor

Addressed feature request #1210

Now when there is a conflict (either on startup or after an attempted merge) that cannot be resolved, a popup appears and the view switches to the first conflict to resolve.

image

image

Also, previously tool tip erroneously repeated --theirs when hovering over USE MINE
Now it correctly says --ours:

image

As per sourcegit-scm#1210.
Included conflict popup + switched focus for immediate conflict handling.
Tooltip for chosing mine was wrong.
Was --theirs when should be --ours.
@love-linger
Copy link
Collaborator

I've picked the commit 26a4719 manually.

I do not like the Conflict-Popup design. See #1210

And I do not like the idea that always auto-selecting the LOCAL CHANGES page when there're conflicts. There're two reasons:

  • In-progress operation may not only due to conflicts, but also empty commits or waiting user to edit commit in interactive-rebase.
  • In this PR, every time after SetData being called (generally after SourceGit detected the files in your worktree have been changed), the LOCAL CHANGES will be selected if there are conflicts. Imagine the following situation: when a conflict occurs, the user switches to the HISTORY or STASHES page and copies some content from a certain revision of the file to resolve the conflict. But every time after copying, SourceGit will detect file changes and forcefully return to the LOCAL CHANGES page automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants