localization: move strings into resources #1535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBaulch
force-pushed
the
localization
branch
from
6391867 to
a71549b
Compare
NathanBaulch
changed the title
|
App.Text add "Text." before. App.Text("Text.InteractiveRebase.Pick") it's just App.Text("InteractiveRebase.Pick"), no? |
NathanBaulch
force-pushed
the
localization
branch
from
a71549b to
e3795e2
Compare
|
Good point @xavierdono, fixed! |
love-linger
reviewed
Jul 8, 2025
| @@ -140,17 +140,17 @@ private void OnButtonActionClicked(object sender, RoutedEventArgs e) | |||
| flyout.Placement = PlacementMode.BottomEdgeAlignedLeft; | |||
| flyout.VerticalOffset = -4; | |||
|
|
|||
| CreateActionMenuItem(flyout, Brushes.Green, "Pick", "Use this commit", "P", item, Models.InteractiveRebaseAction.Pick); | |||
There was a problem hiding this comment.
Action name like Pick, Squash etc. should not be translated.
There was a problem hiding this comment.
Sure, in that case can we use the enum name?
NathanBaulch
force-pushed
the
localization
branch
from
e3795e2 to
7e4f62c
Compare
NathanBaulch
force-pushed
the
localization
branch
from
7e4f62c to
3ae9a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found 22 static strings that weren't localizable. I took a guess at the key names, feel free to rename.