Skip to content

Make NumericSort use InvariantCulture for text comparison #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

Make NumericSort use InvariantCulture for text comparison #1724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Models/NumericSort.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ public static class NumericSort
{
public static int Compare(string s1, string s2)
{
var comparer = StringComparer.InvariantCultureIgnoreCase;

int len1 = s1.Length;
int len2 = s2.Length;

Expand All @@ -20,7 +22,7 @@ public static int Compare(string s1, string s2)
bool isDigit1 = char.IsDigit(c1);
bool isDigit2 = char.IsDigit(c2);
if (isDigit1 != isDigit2)
return c1.CompareTo(c2);
return comparer.Compare(c1.ToString(), c2.ToString());

int subLen1 = 1;
while (marker1 + subLen1 < len1 && char.IsDigit(s1[marker1 + subLen1]) == isDigit1)
Expand All @@ -40,7 +42,7 @@ public static int Compare(string s1, string s2)
if (isDigit1)
result = (subLen1 == subLen2) ? string.CompareOrdinal(sub1, sub2) : (subLen1 - subLen2);
else
result = string.Compare(sub1, sub2, StringComparison.OrdinalIgnoreCase);
result = comparer.Compare(sub1, sub2);

if (result != 0)
return result;
Expand Down
Loading