Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jaeger on port 4317 #213

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Chickensoupwithrice
Copy link
Contributor

Description

This PR fixes support for Jaeger by ensuring that the gRPC port is 4317 as recommended by the docs


Checklist

Test plan

CI

@marcleblanc2
Copy link
Contributor

marcleblanc2 commented Jan 10, 2025

Hey @Chickensoupwithrice, is there a thread / issue somewhere with an existing discussion on this issue?

I'd like to make sure we've thought through which port numbers we need to be using between which services, and if they've been tested, and if they're consistent across deployment types (here, and here). If this conversation has already been recorded somewhere, please send a link so I can read up on it.

The problem I found and fixed in the Docker Compose repo is that the Jaeger container was configured to try and connect to a port on the otel-collector which otel-collector was not configured to listen to. It doesn't really matter which port it is, as long as they match, and are consistent across deployment types.

I don't think we're actually using Jaeger's collector at all, in either Docker Compose or Helm? We're only using Jaeger as a web UI to query traces from otel-collector.

So, the arg on Jaeger "--collector.otlp.grpc.host-port=:xxxx" needs to match the JAEGER_OTLP_GRPC_PORT environment variable on otel-collector (example).

Realistically, we could clean up a ton of Jaeger and oTel's configs, we don't need this many open ports, causing confusion. The names are bad, we should have separate names to clear up which is the collector, and the Jaeger-query-otel-collector port. It makes my eyes cross when I try to trace this stuff.

@Chickensoupwithrice Chickensoupwithrice marked this pull request as draft January 10, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants