Skip to content

feat: Upload google/guava and apache/pekko SCIP index #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jupblb
Copy link
Member

@jupblb jupblb commented Aug 21, 2025

Added https://github.com/google/guava to SCIP index uploads. Used matrix strategies - I think it'll pay off as we add more repositories. The only disadvantage is that we have some steps strictly related to scip binary (but not too many).

Part of GRAPH-1255. Used amp for editing: thread.

Test plan

jupblb and others added 4 commits August 21, 2025 18:47
- Uses scip-java container to index Google Guava repository
- Similar to index-k8s job but for Java instead of Go

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
- Consolidated two jobs into one with matrix strategy
- Removed redundant parameters (upload_repo, container, install_go)
- Derive values from scip_binary when possible
- Reduced workflow from 112 to ~75 lines

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
Cache Maven artifacts to speed up scip-java runs that download many dependencies

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
…ific commands

- Dropped id parameter, use repository name directly
- Renamed checkout_repo to repository
- Fixed Maven cache key to avoid hashFiles error
- Added case statement to handle scip-go vs scip-java command differences

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-9377a689-7d20-47bd-b80c-ad46731df1b0
@jupblb jupblb requested a review from varungandhi-src August 21, 2025 17:30
@jupblb jupblb self-assigned this Aug 21, 2025
@jupblb jupblb force-pushed the michal/GRAPH-1255 branch from e374c4c to 187e388 Compare August 22, 2025 11:56
Added `apache/pekko` and `arrow-kt/arrow`.
@jupblb jupblb force-pushed the michal/GRAPH-1255 branch from 187e388 to 070a381 Compare August 22, 2025 12:19
@jupblb jupblb changed the title feat: Upload google/guava SCIP index feat: Upload google/guava and apache/pekko SCIP index Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant