Skip to content

Conversation

iBotPeaches
Copy link
Member

fixes: #22

  • Checks for any container under the task to see if any exit codes are non-zero.

Screenshot 2025-08-18 at 3 27 09 PM first non-zero, 2nd zero Screenshot 2025-08-18 at 3 27 25 PM both zero Screenshot 2025-08-18 at 3 27 40 PM first zero, 2nd non-zero

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes container error checking by examining all containers in a task instead of just the first one. The change ensures that any non-zero exit code from any container will cause the deployment to fail.

  • Replaces single-container exit code check with a check across all containers
  • Maintains the same success/failure messaging and behavior
  • Uses jq to filter containers with non-zero exit codes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@iBotPeaches
Copy link
Member Author

Yeah the problem is now that we can get many numerics back (if more than 1 container fails). This will take some more thinking

@iBotPeaches iBotPeaches marked this pull request as draft August 18, 2025 19:38
@jweberst
Copy link
Member

Maybe the solution is to just change to this:

echo -e "${RED}Task returned non-zero exit code. Raw response is below:";

Since there are now multiple containers with multiple exit codes, it would be better to just print the raw response and people can look at output.

@iBotPeaches iBotPeaches marked this pull request as ready for review September 30, 2025 12:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support ECS Monitoring containers alongside deploy task.
2 participants