Skip to content

Conversation

@truittjanney
Copy link

My changes:

  • package.json
  • ci.yml changes for node 24
  • nvmrc for specifying required node version

Copy link
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add an nvmrc file - it pollutes the root of the project and we can rely on the package.json.

Also, the GitHub Action is still using Node 20 - https://github.com/sourcetoad/ssh-socket-action/blob/master/action.yml#L34 so this doesn't meet that request.

Finally, Can you explain a bit about the package removal? It seems we removed actions/github, install and npm. What is reasoning behind that?

Okay, I'll add the nvmrc file back. Didn't know you wouldn't want it.

I removed 'actions/github' by accident. My 2nd commit added it back. As for 'install' and 'npm'. Asked copilot to double check my package.json to make sure what I did was correct. It said that npm is a package manager, and shouldn't be listed as a dependency, so I removed it. And that install is not used in the project and to remove what isn't used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants