Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file after write #84

Merged
merged 8 commits into from
May 28, 2017
Merged

Conversation

zamedic
Copy link
Contributor

@zamedic zamedic commented May 28, 2017

Description

Closes the file after it writes the settings file

Issues Resolved

#81
#77

Check List

[X ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[X ] New functionality includes testing.
[X ] New functionality has been documented in the README if applicable
[X ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

@zamedic
Copy link
Contributor Author

zamedic commented May 28, 2017

Hmmm - not sure how to rerun travis - looks like it timed out :(

@tas50 tas50 merged commit da12caf into sous-chefs:master May 28, 2017
@tas50
Copy link
Contributor

tas50 commented May 28, 2017

Thanks for the work here. In the future we have tooling that handles the version bump and the change log so that part isn't necessary

@zamedic
Copy link
Contributor Author

zamedic commented May 29, 2017

thank you @tas50 - will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants