fix(deep): handle figma.mixed in deep component extraction - #85
Open
DarWiM wants to merge 1 commit into
Open
Conversation
Serialize the deep tree with a JSON replacer that maps Symbol (figma.mixed) to the string "MIXED" and post the parsed clone. This fixes the "Cannot unwrap symbol" crash that aborted the whole deep extraction on text with mixed character styles. Also expand mixed values into full data instead of dropping them: - mixed per-character text -> styledSegments[] (per-range fontName, fontSize, fontWeight, textDecoration, textCase, lineHeight, letterSpacing, fills, textStyleId, fillStyleId) - mixed cornerRadius -> cornerRadiuses (per corner) - mixed strokeWeight -> strokeWeights (per side) - fix missing braces so fontStyle is not read off a mixed fontName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize the deep tree with a JSON replacer that maps Symbol (figma.mixed) to the string "MIXED" and post the parsed clone. This fixes the "Cannot unwrap symbol" crash that aborted the whole deep extraction on text with mixed character styles.
Also expand mixed values into full data instead of dropping them: