Skip to content

Cargo holoprojector#652

Open
Gopararelav wants to merge 4 commits intospace-syndicate:masterfrom
Gopararelav:holoprojector
Open

Cargo holoprojector#652
Gopararelav wants to merge 4 commits intospace-syndicate:masterfrom
Gopararelav:holoprojector

Conversation

@Gopararelav
Copy link

Описание PR

Добавлен голографический проектор ящиков, которые существуют 5 минут.

Почему / Баланс

Грузчикам будет полезно иметь бесконечный источник ящиков, появляется в шкафчике квартирмейстера

Технические детали

В компонент HolosignProjector добавлено поле anchor

Медиа

Требования

Список изменений

@KillanGenifer
Copy link
Collaborator

медиа сука где

Copy link

@cfif126 cfif126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Локаль хорошо, нужно удалить запятые в англ

parent: Holoprojector
id: HoloprojectorCrate
name: holocrate holoprojector
description: A projector that creates a temporary, hard light crate.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: A projector that creates a temporary, hard light crate.
description: A projector that creates a temporary hard light crate.

@@ -0,0 +1,2 @@
ent-HoloprojectorCrate = holocrate holoprojector
.desc = A projector that creates a temporary, hard light crate.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.desc = A projector that creates a temporary, hard light crate.
.desc = A projector that creates a temporary hard light crate.

Copy link
Collaborator

@KillanGenifer KillanGenifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Требует внутриигровой проверки

"y": 32
},
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at https://github.com/tgstation/tgstation/commit/40d89d11ea4a5cb81d61dc1018b46f4e7d32c62a, inhands by TiniestShark (GitHub)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ты хоть проверяй куда отсылается ссылка

Comment on lines +33 to +35
// CorvaxGoob
[DataField]
public bool Anchor = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавить комментарий + дать более понятное название параметру. Например AnchorOnSpawn

// Goob edit end
var xform = Transform(holoUid);
if (!xform.Anchored)
if (!xform.Anchored && component.Anchor == true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no cgb repo commentary + можно упростить до

Suggested change
if (!xform.Anchored && component.Anchor == true)
if (!xform.Anchored && component.Anchor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants