arducam driver

[KantaTamura]

arducam driverをyoctoに移植した

動作確認はできていないです

[yashi]

良さげです。

なぜドライバーを追加する必要があるのか、だけ commit message に書いてください。コピーしてきた版の commit hash も入れておいてもらえると助かります。

あとは @MayaAbe か @sasataku のテスト結果が OKなら、マージで。

[yashi]

@MayaAbe のテスト待ち

[KantaTamura]

末尾に改行を加えた結果md5の値が変わっていたので，その部分のみ修正しました

[MayaAbe]

カメラの動確のためにlibcameraを入れられますか？
@KantaTamura

[sasataku]

kirkstone (kernel 5.15.34)で、libcameraを使ってArducam Cameraが動作したので PRを更新しています。
libcamera-appsは入れていないので、動作確認は cam コマンドのみです。

• cam -l (使用可能なカメラのリスト表示)
• cam -c 1 --capture=10 -F (10 Frame分のキャプチャ&ファイル保存)

[yashi]

Is the library based on https://github.com/ArduCAM/Arducam_dvp?

[yashi]

I couldn't find license information for the binary file. Do you have it?

[yashi]

Is the library based on https://github.com/ArduCAM/Arducam_dvp?

I guess not.

[yashi]

This is more like "Arducam fork of libcamera", no?

[yashi]

Or if you want to keep the orignal, "Arducam fork of Linux libcamera framework"

[sasataku]

Will change to "Arducam fork of Linux libcamera framework"

[yashi]

This is the diff between this file and the original. Is it still better to fork it instead of overlay?

diff -u meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb ~/work/launch2022/rpi-zero/zero/meta-arducam/recipes-multimedia/libcamera-arducam/libcamera-arducam_0.0.5.bb 
--- meta-multimedia/recipes-multimedia/libcamera/libcamera_0.1.0.bb	2023-09-18 21:42:16.622746910 +0900
+++ /home/yashi/work/launch2022/rpi-zero/zero/meta-arducam/recipes-multimedia/libcamera-arducam/libcamera-arducam_0.0.5.bb	2023-09-18 21:32:04.688421677 +0900
@@ -1,4 +1,4 @@
-SUMMARY = "Linux libcamera framework"
+SUMMARY = "Arducam libcamera framework"
 SECTION = "libs"
 
 LICENSE = "GPL-2.0-or-later & LGPL-2.1-or-later"
@@ -9,16 +9,16 @@
 "
 
 SRC_URI = " \
-        git://git.libcamera.org/libcamera/libcamera.git;protocol=https;branch=master \
+        git://github.com/ArduCAM/libcamera.git;protocol=https;branch=arducam \
 "
 
-SRCREV = "960d0c1e19feaf310321c906e14bd5410c6be629"
+SRCREV = "bde06144d10d4a201e761218ba9169d7a00446e6"
 
 PE = "1"
 
 S = "${WORKDIR}/git"
 
-DEPENDS = "python3-pyyaml-native python3-jinja2-native python3-ply-native python3-jinja2-native udev gnutls chrpath-native libevent libyaml"
+DEPENDS = "python3-pyyaml-native python3-jinja2-native python3-ply-native python3-jinja2-native udev gnutls chrpath-native libevent libyaml arducam-pivariety"
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'qt', 'qtbase qtbase-native', '', d)}"
 
 PACKAGES =+ "${PN}-gst"
@@ -26,10 +26,9 @@
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[gst] = "-Dgstreamer=enabled,-Dgstreamer=disabled,gstreamer1.0 gstreamer1.0-plugins-base"
 
-LIBCAMERA_PIPELINES ??= "auto"
-
 EXTRA_OEMESON = " \
-    -Dpipelines=${LIBCAMERA_PIPELINES} \
+    -Dpipelines=rpi/vc4 \
+    -Dipas=rpi/vc4 \
     -Dv4l2=true \
     -Dcam=enabled \
     -Dlc-compliance=disabled \
@@ -46,8 +45,7 @@
 }
 
 do_install:append() {
-    chrpath -d ${D}${libdir}/libcamera.so
-    chrpath -d ${D}${libexecdir}/libcamera/v4l2-compat.so
+    rm -rf ${D}/usr/share
 }
 
 addtask do_recalculate_ipa_signatures_package after do_package before do_packagedata
@@ -63,10 +61,8 @@
     ${S}/src/ipa/ipa-sign-install.sh ${B}/src/ipa-priv-key.pem "${modules}"
 }
 
-FILES:${PN} += " ${libexecdir}/libcamera/v4l2-compat.so"
-FILES:${PN}-gst = "${libdir}/gstreamer-1.0"
+FILES:${PN} += " ${libdir}/v4l2-compat.so ${libdir}/libcamera/ipa*"
 
 # libcamera-v4l2 explicitly sets _FILE_OFFSET_BITS=32 to get access to
 # both 32 and 64 bit file APIs.
 GLIBC_64BIT_TIME_FLAGS = ""
-

[sasataku]

Yes, I was also wondering if I should overlay with bbapend.
I will try to change to use a bbapend.

[sasataku]

Unfortunately, do_install fails because the libcamera version targeted by kirkstone's libcamera recipe and
the arducam libcamera version do not match.

So, we forked the recipece from commit below and modified it

[yashi]

Please create the symlink in do_install().

[sasataku]

OKay. will create in do_install().

[yashi]

If the library is non-distributable, we have to do something.

[sasataku]

Now I'm asking the license information in Arducam forum.
https://forum.arducam.com/t/what-is-the-license-for-arducam-pivariety-sdk-dev/5760

[yashi]

Missed .hpp in -dev?

[sasataku]

Thanks. will fix.

[yashi]

I don't know where to put my comment on the commit log so here goes.

• please check english grammer.
• The arducam_ppa provides packages and there is a package providing a pre-built "binary".
• The word "various" isn't the right word because you are installing .so and .hpp. You should generate the symlink.
• this "Libcamera's build system utilizes the first pkgconfig to search for this SDK, so it also installs .pc file." isn't right. libcamera uses pkgconfig (or pkg-config). pkgconfig uses the first matched .pc file (if it's true; I haven't tested).
• This "It used the following page as a reference for how to install pre-built packages with Yocto." is unbigous. Since we were just talking about "Libcamera's build system", "pkgconfig", or the .pc file, the word "it" sounds like referencing one of them. Instead I'm sure you are referencing the .bb file.

[yashi]

my take:

zero/meta-arducam: Install libarducam_pivariety.so.1.0.2 from Arducam SDK

This commit adds pre-built libarducam_pivariety.so taken from Arducam SDK.

Arducam has extended libcamera source code and has published it on
GitHub. However, the source code needs libarducam_pivariety.so and
it's header file to build and run.

• https://github.com/ArduCAM/arducam_ppa
  arducam-pivariety-sdk-dev

(We should add SHA hash or tags where we obtained files)
(We should add list of files taken from the package)

Libcamera build system utilizes pkgconfig and pkgconfig utilizes the
first .pc, we are adding the .pc file to -dev package as well.

The arducam-pivariety_1.0.2.bb was writen referencing the following
page: "Working with Pre-Built Libraries"

• https://docs.yoctoproject.org/dev/dev-manual/prebuilt-libraries.html

Please update hash value, tags, package name, list of files taken.

[sasataku]

Thanks. will update commit log and add SHA hash.etc.

[yashi]

BTW, if the files are taken from someother places, you don't need to fix it. But please write it down where you've got them from.

It has been fixed, so dismiss review and merge to master.