fix(skill): tag the way this repository actually tags, and stamp the sync marker - #234
Merged
Merged
Conversation
…sync marker Two loose ends from cutting v0.17.0, the first real run of `cargento-release`. Step 5 said `git tag "v$VERSION"`. On a machine with `tag.gpgsign true` that tries to create a signed tag, finds no message, and dies with `no tag message?` before anything reaches the remote. It failed on the release it was written for. The fix is `git -c tag.gpgsign=false`, which forces the lightweight form. That is what this repository's release tags are (`git cat-file -t v0.16.0` prints `commit`, not `tag`) and it is what the workflow's own `git tag -f` re-creates when it moves the tag onto the bump commit, so the override matches the end state rather than working around it. Where signing is off it does nothing. A `git cat-file -t` check rides along because the wrong outcome is silent in the other direction: an annotated tag pushes fine and the mismatch only shows up later. Rehearsed this time rather than reasoned about: created a throwaway tag locally, confirmed `commit`, deleted it, and confirmed the bare form still fails. The comment in the skill records why that rehearsal is possible and why the original command was the one that went untested. Also stamps `docs-synced-through` from `0f9d086` to `ec10918`, per AGENTS.md's rule to advance it once from main after merges rather than per branch. The range covers four commits: the previous stamp (#231), the sessions-table title label (#232), the `cargento-release` skill itself (#233), and the v0.17.0 release bump. Signed-off-by: Jared Scott <jared.scott@variable.team>
Contributor
CoverageThreshold: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two loose ends from cutting v0.17.0, which was the first real run of
cargento-release.The tag command was wrong
Step 5 said
git tag "v$VERSION". On a machine withtag.gpgsign truethat tries to create a signed tag, finds no message, and dies:It failed on the release it was written for.
The fix is
git -c tag.gpgsign=false tag, which forces the lightweight form. That is what this repository's release tags actually are (git cat-file -t v0.16.0printscommit, nottag), and it is what the Release workflow's owngit tag -fre-creates when it moves the tag onto the bump commit. So the override matches the end state rather than working around it, and where signing is off it does nothing. Agit cat-file -tassertion rides along because the wrong outcome is silent in the other direction: an annotated tag pushes fine and you would only discover the mismatch later.Rehearsed rather than reasoned about this time. Created a throwaway tag locally, confirmed type
commit, deleted it, and confirmed the bare form still fails, so the override is load bearing rather than cosmetic.The skill now records why this one slipped: every other command in it was run before it was written down, and the tag command was the only one that could not be rehearsed against the real remote. It can be rehearsed locally, and the skill says how.
The sync marker
docs-synced-throughmoves from0f9d086toec10918, per AGENTS.md's rule to advance it once frommainafter merges rather than per branch. The release run reported it as behind rather than stamping it silently, which is what that rule asks for.The range covers four commits: the previous stamp (#231), the sessions-table title label (#232), the
cargento-releaseskill (#233), and thechore(release): v0.17.0bump.Verification
Full pre-PR suite green: ruff,
ruff format --check,mypy --strict(108 files),lint_embedded.py(node present),validate_plugins.py, 1,935 dashboard tests + 192 scripts tests OK.bump_version.py --currentreads0.17.0, confirming the release landed, and no manifest is in this diff.