thorlabs_mcls1: add OS-based backend selection (Windows UART lib / Linux serial)#441
Merged
Conversation
Collaborator
|
@ivalaginja I also recently used an mcls1 and made some changes to work directly with pyserial nearly the same time you started working this. I can test your changes on Windows |
RemiSoummer
force-pushed
the
mcls1_serial_service
branch
from
39eaca8 to
8e5028d
Compare
RemiSoummer
approved these changes
Jun 1, 2026
RemiSoummer
left a comment
RemiSoummer
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and tested on both linux and windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
ThorlabsMcls1service to support both Windows and Linux/macOS communication paths while keeping a single service implementation.The MCLS1 service previously depended on the Thorlabs UART library flow, which is Windows-specific. We need the same service to work on non-Windows systems using direct serial communication (e.g., Linux).
I added runtime backend selection based on OS, and refactored all necessary methods to call one or the other, depending on the backend.
Backward-compatible for existing Windows setups (same UART library behavior).
Adds non-Windows support without introducing a second service class.
TODO