HLA-960: Improve Guiding Failure Check for MVM processing#2101
Open
s-goldman wants to merge 25 commits into
Open
HLA-960: Improve Guiding Failure Check for MVM processing#2101s-goldman wants to merge 25 commits into
s-goldman wants to merge 25 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves HLA-960
Closes #
This PR improves the verify_guiding function which identifies exposures with guidance errors during MVM processing. The code change mainly tries to limit the number programs mis-identified as having guide star issues. These programs have exposures with linear-looking PSF spikes or CTE issues that are being confused as smeared stars.
An analysis of the impact of these changes can be found here: Improving MVMs Products Degraded by Guide Star Issues.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionRegression test: https://github.com/spacetelescope/RegressionTests/actions/runs/26229493149