Use Photutils 3+ use_future_column_names context manager#2153
Merged
Conversation
s-goldman
added
code cleanup
s-goldman
approved these changes
May 20, 2026
Collaborator
|
@larrybradley Feel free to merge this when you are ready. |
Member
Author
|
@s-goldman I don't have permissions to merge: Merging is blocked |
Collaborator
|
Ahh, apologies. I'll go ahead and merge this then. Thanks for helping us with this transition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves HLA-nnnn
This PR is a followup to #2139 to use the
use_future_column_namescontext manager for locally-scoped changes instead of thefuture_column_namesglobal variable. This is a better approach ifphotutilsis also being used outside of drizzlepac (the global variable isn't mutated) so users will not be surprised.I've also updated the
minversionnow that photutils 3.0 is released.CC: @s-goldman
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionRegression test:
https://github.com/spacetelescope/RegressionTests/actions/runs/26179736913