JP-4326: Allow multi-band direct imaging input to wfss_contam#10463
JP-4326: Allow multi-band direct imaging input to wfss_contam#10463emolter wants to merge 28 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10463 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 375 375
Lines 40347 40396 +49
=======================================
+ Hits 35050 35096 +46
- Misses 5297 5300 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@emolter - I think this branch is intended for INS to test a possible solution, but there are some conflicts. Can we clean it up? |
|
Thanks for the bump Melanie, merge should be done now. FYI at the WFSS working group meeting it sounded like there won't be personnel to test this until after the build deadline, so we've deferred it to build 13.2. I removed the 13.0 tag already. But point well taken that I should periodically ensure it's up-to-date with other changes. |
|
regtests with spacetelescope/stdatamodels#756: https://github.com/spacetelescope/RegressionTests/actions/runs/27351610540 Not sure what's up with the two association test failures, as I did not touch the asns at all here. |
Resolves JP-4326
Requires spacetelescope/stdatamodels#756
This PR adds a user reprocessing option to the
WfssContamStepthat allows passing a multi-wavelength direct image cube into the step instead of a single direct image. This allows the simulated dispersed flux to have an arbitrary spectral shape instead of always assuming a flat spectrum. See the ticket and docstring for more details.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files