JP-4313: Support NIRCam superstripe modes#10534
Open
melanieclarke wants to merge 26 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10534 +/- ##
==========================================
+ Coverage 86.86% 86.91% +0.04%
==========================================
Files 375 375
Lines 40346 40463 +117
==========================================
+ Hits 35047 35167 +120
+ Misses 5299 5296 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
146f3f2 to
a668783
Compare
8 tasks
27d4651 to
7578e64
Compare
226ad3b to
27efade
Compare
Collaborator
Author
|
Regtests: All passing. |
7a53a18 to
0a3e5de
Compare
Collaborator
Author
|
Stcal and stdatamodels PRs are merged. I'll rerun regtests on this branch: All passing still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4313
Updates to stripe handling for new NIRCam imaging superstripe modes, through detector1.
The new modes will include some with pure super stripes: no reference pixels included. In this case, reference pixels are skipped via the subarray start value, and all skip and read values are 0.
The new modes also include some with a combination of substripe reference pixels, superstripe science, and repeated stripes for in-frame up-the-ramp samples. These will need special handling in ramp fitting and reassembly.
Other changes here:
Requires spacetelescope/stdatamodels#739 for new subarray names and read_times metadata
Requires spacetelescope/stcal#546 to support read times for in-frame samples.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files