Skip to content

JP-4313: Support NIRCam superstripe modes#10534

Open
melanieclarke wants to merge 26 commits into
spacetelescope:mainfrom
melanieclarke:jp-4313
Open

JP-4313: Support NIRCam superstripe modes#10534
melanieclarke wants to merge 26 commits into
spacetelescope:mainfrom
melanieclarke:jp-4313

Conversation

@melanieclarke

@melanieclarke melanieclarke commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Resolves JP-4313

Updates to stripe handling for new NIRCam imaging superstripe modes, through detector1.

The new modes will include some with pure super stripes: no reference pixels included. In this case, reference pixels are skipped via the subarray start value, and all skip and read values are 0.

The new modes also include some with a combination of substripe reference pixels, superstripe science, and repeated stripes for in-frame up-the-ramp samples. These will need special handling in ramp fitting and reassembly.

Other changes here:

  • add stripe_utils API to RTD
  • move superstripe test data helpers from the dq_init module to lib

Requires spacetelescope/stdatamodels#739 for new subarray names and read_times metadata
Requires spacetelescope/stcal#546 to support read times for in-frame samples.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.91%. Comparing base (9136ddc) to head (ade0b52).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10534      +/-   ##
==========================================
+ Coverage   86.86%   86.91%   +0.04%     
==========================================
  Files         375      375              
  Lines       40346    40463     +117     
==========================================
+ Hits        35047    35167     +120     
+ Misses       5299     5296       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke

melanieclarke commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

@melanieclarke melanieclarke force-pushed the jp-4313 branch 2 times, most recently from 7a53a18 to 0a3e5de Compare June 2, 2026 16:31
@melanieclarke melanieclarke marked this pull request as ready for review June 2, 2026 16:31
@melanieclarke melanieclarke requested a review from a team June 2, 2026 16:31
@melanieclarke

melanieclarke commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Stcal and stdatamodels PRs are merged. I'll rerun regtests on this branch:
https://github.com/spacetelescope/RegressionTests/actions/runs/27367906251

All passing still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants