Skip to content

JP-3975: Exclude dhs subarrays from tso3 asn rule#10567

Draft
tapastro wants to merge 5 commits into
spacetelescope:mainfrom
tapastro:jp-3975-no-l3-asn
Draft

JP-3975: Exclude dhs subarrays from tso3 asn rule#10567
tapastro wants to merge 5 commits into
spacetelescope:mainfrom
tapastro:jp-3975-no-l3-asn

Conversation

@tapastro

Copy link
Copy Markdown
Contributor

Partially addresses JP-3975

This PR removes undesirable level 3 associations being generated for long-wavelength NIRCam DHS exposures.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@tapastro tapastro added this to the Build 13.0 milestone May 20, 2026
@tapastro

tapastro commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

RTs https://github.com/spacetelescope/RegressionTests/actions/runs/26188072813

Old RTs showed no failures, in part because our DHS pool contained only engineering imaging data and no DHS subarray data. I've updated the pool to use DHS subarray data, new set here: https://github.com/spacetelescope/RegressionTests/actions/runs/26531659627

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.58%. Comparing base (094969c) to head (f5d23fc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10567   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files         374      374           
  Lines       40440    40440           
=======================================
  Hits        35015    35015           
  Misses       5425     5425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapastro tapastro force-pushed the jp-3975-no-l3-asn branch from 168d226 to 3057b45 Compare May 21, 2026 14:14
@tapastro tapastro force-pushed the jp-3975-no-l3-asn branch from 3057b45 to 77c495e Compare May 26, 2026 14:16
@tapastro

tapastro commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Unnoticed jfrog upload issue, no truth files present... also a refactor to place the update inside the new constraint. Fresh RTs here, which should hopefully pass: https://github.com/spacetelescope/RegressionTests/actions/runs/26578325827

@tapastro

Copy link
Copy Markdown
Contributor Author

The refactor of the rule means that the rule will not exclude NRC_TSGRISM data with pupil=CLEAR but not in stripe subarrays, which I believe the past rule was excluding. That said, there are no instances of this in MAST, so I think it may be an inconsequential change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant