JP-3975: Exclude dhs subarrays from tso3 asn rule#10567
Conversation
|
RTs https://github.com/spacetelescope/RegressionTests/actions/runs/26188072813 Old RTs showed no failures, in part because our DHS pool contained only engineering imaging data and no DHS subarray data. I've updated the pool to use DHS subarray data, new set here: https://github.com/spacetelescope/RegressionTests/actions/runs/26531659627 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10567 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 374 374
Lines 40440 40440
=======================================
Hits 35015 35015
Misses 5425 5425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
168d226 to
3057b45
Compare
3057b45 to
77c495e
Compare
|
Unnoticed jfrog upload issue, no truth files present... also a refactor to place the update inside the new constraint. Fresh RTs here, which should hopefully pass: https://github.com/spacetelescope/RegressionTests/actions/runs/26578325827 |
|
The refactor of the rule means that the rule will not exclude NRC_TSGRISM data with pupil=CLEAR but not in stripe subarrays, which I believe the past rule was excluding. That said, there are no instances of this in MAST, so I think it may be an inconsequential change. |
Partially addresses JP-3975
This PR removes undesirable level 3 associations being generated for long-wavelength NIRCam DHS exposures.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files