Adding the ability to publish to Maven Central#3
Merged
Merged
Conversation
|
alphasentaurii
requested changes
Oct 21, 2025
alphasentaurii
left a comment
alphasentaurii
left a comment
Collaborator
There was a problem hiding this comment.
Only feedback is we won't need to publish github packages once they're available on maven, and the run tests steps prior to deploy seems redundant since the tests will have already been run for the commit being released.
|
alphasentaurii
approved these changes
Oct 27, 2025
alphasentaurii
left a comment
alphasentaurii
left a comment
Collaborator
There was a problem hiding this comment.
LGTM thanks Brendan
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality to allow for publishing of bundles to the Maven Central namespace edu.stsci . Default behavior is to publish to both Github and Maven Central, but you can manually deploy to either.