Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin numpy<2 #265

Merged
merged 2 commits into from
Jun 17, 2024
Merged

pin numpy<2 #265

merged 2 commits into from
Jun 17, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 17, 2024

Numpy 2.0 is out.

OpenCV is not numpy 2.0 compatible (see opencv/opencv-python#943) causing many failures for stcal:
https://github.com/spacetelescope/stcal/actions/runs/9544922911/job/26304635960

This PR pins numpy to <2.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram requested a review from a team as a code owner June 17, 2024 14:02
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (af5aefb) to head (12699ec).
Report is 114 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   85.18%   83.79%   -1.39%     
==========================================
  Files          35       35              
  Lines        6797     6998     +201     
==========================================
+ Hits         5790     5864      +74     
- Misses       1007     1134     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit 80b842b into spacetelescope:main Jun 17, 2024
23 of 25 checks passed
@braingram braingram deleted the pin_numpy branch June 17, 2024 18:43
braingram added a commit to braingram/stcal that referenced this pull request Jun 18, 2024
This reverts commit 80b842b, reversing
changes made to 2b257df.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants