Deprecate DataModel in favor of JwstDataModel#676
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 90.44% 90.36% -0.09%
==========================================
Files 99 98 -1
Lines 4690 4692 +2
==========================================
- Hits 4242 4240 -2
- Misses 448 452 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tapastro this is still in the investigation phase. It'd be helpful to get your take on whether we want to do this, i.e., do the benefits (code and docs readability/maintainability, clarity on intended base class for downstream use) outweigh the potential for disrupting people's code downstream that might be using |
8f82c47 to
4d64a17
Compare
|
Perhaps relevant to this PR, LIGER evidently uses |
Closes #581
This PR combines
DataModelwithJwstDataModeland deprecatesDataModel.In this version the code for
JwstDataModelwould live atsrc/stdatamodels/model_base.pybut available to be imported as bothfrom stdatamodels import JwstDataModelandfrom stdatamodels.jwst.datamodels import JwstDataModel. The latter is widely used already.Requires spacetelescope/jwst#10288 to fix one instance where the pipeline was doing
from stdatamodels.jwst.datamodels.model_base import JwstDataModel. This construction would no longer work, but since it's (hopefully) not in wide use that should be ok.Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change