Skip to content

JP-3944: New ref file type for NIRSpec chromaticity correction#743

Merged
emolter merged 16 commits into
spacetelescope:mainfrom
emolter:JP-3944
Jun 9, 2026
Merged

JP-3944: New ref file type for NIRSpec chromaticity correction#743
emolter merged 16 commits into
spacetelescope:mainfrom
emolter:JP-3944

Conversation

@emolter

@emolter emolter commented May 15, 2026

Copy link
Copy Markdown
Contributor

Relates to JP-3944

See companion JWST PR here: spacetelescope/jwst#10556

This PR adds a new reference file type in support of the NIRSpec IFU chromaticity correction.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.72%. Comparing base (a1358d6) to head (ca4bdaf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   90.71%   90.72%   +0.01%     
==========================================
  Files          99       99              
  Lines        4597     4605       +8     
==========================================
+ Hits         4170     4178       +8     
  Misses        427      427              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter changed the title JP-3944: New ref file type for chromaticity correction JP-3944: New ref file type for NIRSpec chromaticity correction May 15, 2026
@emolter

emolter commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

@melanieclarke melanieclarke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be helpful to have another datamodels expert review.

@braingram - this is still in draft because it needs CRDS support before we can move forward, but an advance review would be helpful if you have time.

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes look complete to me.

I pulled down one of the example files from the JP ticket and it has a defined lamp_mode of N/A but the rmap for https://jira.stsci.edu/browse/CRDS-1113 doesn't list that as part of the selector so likely if it is an "issue" that lamp_mode exists it's one with the reference file and not with the datamodel. My initial reaction is that's it's inconsequential but I figured I'd mention it here in case I'm mistaken.

@emolter emolter marked this pull request as ready for review June 9, 2026 16:09
@emolter emolter requested a review from a team as a code owner June 9, 2026 16:09
@emolter emolter requested a review from melanieclarke June 9, 2026 16:09

@melanieclarke melanieclarke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and merge this since it will have no impact with jwst on main, and is working with the files available on CRDS test. One less thing to remember to do later when CRDS test merges with ops...

@emolter emolter merged commit fd7e0ca into spacetelescope:main Jun 9, 2026
22 checks passed
@emolter emolter deleted the JP-3944 branch June 9, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants