Skip to content

use local build workflow with wheel binary attestations#745

Open
zacharyburnett wants to merge 2 commits into
spacetelescope:mainfrom
zacharyburnett:local_build_workflow
Open

use local build workflow with wheel binary attestations#745
zacharyburnett wants to merge 2 commits into
spacetelescope:mainfrom
zacharyburnett:local_build_workflow

Conversation

@zacharyburnett

@zacharyburnett zacharyburnett commented May 19, 2026

Copy link
Copy Markdown
Collaborator

as part of the usage of PyPI Trusted Publishers, shifts the build workflow from using the reusable OpenAstronomy workflow to a local build.yml that also includes attestation of the wheel

I'll also work on adding the ability to use a test-command for testing the wheel

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@zacharyburnett zacharyburnett requested a review from a team as a code owner May 19, 2026 18:17
@zacharyburnett zacharyburnett marked this pull request as draft May 19, 2026 18:17
@zacharyburnett zacharyburnett added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label May 19, 2026
@zacharyburnett zacharyburnett self-assigned this May 19, 2026
@zacharyburnett zacharyburnett force-pushed the local_build_workflow branch 2 times, most recently from 8e2fe87 to 3303b78 Compare May 19, 2026 18:18
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.62%. Comparing base (f43d584) to head (9d1115c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #745   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files          99       99           
  Lines        4577     4577           
=======================================
  Hits         4148     4148           
  Misses        429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram

Copy link
Copy Markdown
Collaborator

The version doesn't look correct:
https://github.com/spacetelescope/stdatamodels/actions/runs/26116545849/job/76807191324?pr=745#step:5:76

creating stdatamodels-0.1.0.dev1+g047bb941a/tests/schemas

@zacharyburnett zacharyburnett force-pushed the local_build_workflow branch from 3303b78 to c56280c Compare May 19, 2026 18:38
@zacharyburnett

Copy link
Copy Markdown
Collaborator Author

The version doesn't look correct: https://github.com/spacetelescope/stdatamodels/actions/runs/26116545849/job/76807191324?pr=745#step:5:76

creating stdatamodels-0.1.0.dev1+g047bb941a/tests/schemas

that's unexpected, I just pushed all the tags from this repository to my fork and re-ran the workflow but it still says 0.1.0

@zacharyburnett

zacharyburnett commented May 19, 2026

Copy link
Copy Markdown
Collaborator Author

another PR from my fork using the OpenAstronomy workflow seems to pick up the correct version: https://github.com/spacetelescope/stdatamodels/actions/runs/26117945220/job/76812039922?pr=720#step:6:2033

Successfully built stdatamodels-5.1.0.dev89+g42ec31921-py3-none-any.whl

@zacharyburnett zacharyburnett force-pushed the local_build_workflow branch from 0cdc3ef to a9f12e6 Compare May 20, 2026 12:52
@zacharyburnett

Copy link
Copy Markdown
Collaborator Author

alright, setting fetch-depth: 0 fixed it; fetch-tags: true alone was not enough

@zacharyburnett zacharyburnett marked this pull request as ready for review May 20, 2026 12:53
@zacharyburnett zacharyburnett force-pushed the local_build_workflow branch from a9f12e6 to a622504 Compare May 20, 2026 12:54
@zacharyburnett zacharyburnett marked this pull request as draft May 20, 2026 13:02
@zacharyburnett zacharyburnett marked this pull request as ready for review May 20, 2026 13:17
@zacharyburnett

Copy link
Copy Markdown
Collaborator Author

using check-wheel-contents we can run a few checks against the wheel, including module availability, without having to install it into a virtualenv (which would require parsing compatible Python versions and installing dependencies):
https://github.com/jwodder/check-wheel-contents

@braingram

Copy link
Copy Markdown
Collaborator

using check-wheel-contents we can run a few checks against the wheel, including module availability, without having to install it into a virtualenv (which would require parsing compatible Python versions and installing dependencies): https://github.com/jwodder/check-wheel-contents

Let's not add that new package/tool as part of this change.

@zacharyburnett zacharyburnett force-pushed the local_build_workflow branch 2 times, most recently from d311ae3 to 9d1115c Compare May 20, 2026 13:34
@zacharyburnett

zacharyburnett commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

after merge, the named status check requirement in settings will have to be updated from build / Build source and wheel distribution to just build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed Trivial change that doesn't need an entry in the change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants