Skip to content

JP-4144: Update number of characters in SUBARRAY and READPATT table entries#759

Open
drlaw1558 wants to merge 5 commits into
spacetelescope:mainfrom
drlaw1558:jp4144_and_jp4302
Open

JP-4144: Update number of characters in SUBARRAY and READPATT table entries#759
drlaw1558 wants to merge 5 commits into
spacetelescope:mainfrom
drlaw1558:jp4144_and_jp4302

Conversation

@drlaw1558

@drlaw1558 drlaw1558 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Partially resolves JP-4144 by increasing the number of characters available to the SUBARRAY keyword for various data models.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@drlaw1558 drlaw1558 requested a review from a team as a code owner June 11, 2026 21:43
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (904f3c1) to head (7437112).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          99       99           
  Lines        4619     4619           
=======================================
  Hits         4188     4188           
  Misses        431      431           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drlaw1558

Copy link
Copy Markdown
Contributor Author

Tagging @jemorrison

@jemorrison

Copy link
Copy Markdown
Contributor

@drlaw1558 Please remove the rscd ones. They have been tested/ review and I have run regression test.
They are in #758

@drlaw1558

Copy link
Copy Markdown
Contributor Author

@jemorrison Done

@tapastro

Copy link
Copy Markdown
Collaborator

Changes look reasonable enough, though the description mentions READPATT changes - I don't see any of those here. Were they dropped accidentally from the PR, or should that be removed from the changelog fragment?

@tapastro

Copy link
Copy Markdown
Collaborator

@drlaw1558

Copy link
Copy Markdown
Contributor Author

READPATT used to be in here too, but that got dropped so as not to step on @jemorrison 's other PR. I've updated the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants