JP-4144: Update number of characters in SUBARRAY and READPATT table entries#759
JP-4144: Update number of characters in SUBARRAY and READPATT table entries#759drlaw1558 wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 99 99
Lines 4619 4619
=======================================
Hits 4188 4188
Misses 431 431 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tagging @jemorrison |
|
@drlaw1558 Please remove the rscd ones. They have been tested/ review and I have run regression test. |
|
@jemorrison Done |
|
Changes look reasonable enough, though the description mentions READPATT changes - I don't see any of those here. Were they dropped accidentally from the PR, or should that be removed from the changelog fragment? |
|
READPATT used to be in here too, but that got dropped so as not to step on @jemorrison 's other PR. I've updated the description. |
Partially resolves JP-4144 by increasing the number of characters available to the SUBARRAY keyword for various data models.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change