Skip to content

kokkos: add v4.6.00 #49810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2025
Merged

kokkos: add v4.6.00 #49810

merged 4 commits into from
Apr 3, 2025

Conversation

rbberger
Copy link
Member

No description provided.

@alecbcs alecbcs changed the title kokkos: add version 4.6.00 kokkos: add v4.6.00 Mar 31, 2025
@rbberger
Copy link
Member Author

@cedricchevalier19 just realized there might be a need to make the async_alloc variant also work with ROCm. Want me to push it here?

@lucbv
Copy link
Contributor

lucbv commented Mar 31, 2025

Can we also add a change below line 204:

        "zen4": "ZEN4",

See PR #7550 in Kokkos

Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about zen4.

@lucbv lucbv requested a review from psakievich April 1, 2025 19:47
@cedricchevalier19
Copy link
Contributor

@cedricchevalier19 just realized there might be a need to make the async_alloc variant also work with ROCm. Want me to push it here?

I do not think we want to expose it. For Cuda, it was blocking users with some MPI implementations, but tests have not shown this kind of issue for ROCm.

@lucbv lucbv requested a review from tldahlgren April 3, 2025 14:45
@rbberger rbberger enabled auto-merge (squash) April 3, 2025 16:35
@rbberger
Copy link
Member Author

rbberger commented Apr 3, 2025

@tldahlgren can you give us the missing approval? I don't want to approve my own PR ;-)

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Re]Confirmed all of the affected sha256s.

@rbberger rbberger merged commit 9acb70f into spack:develop Apr 3, 2025
17 checks passed
@tldahlgren tldahlgren self-assigned this Apr 3, 2025
@rbberger rbberger deleted the updates/kokkos branch April 3, 2025 19:56
ndellingwood added a commit to ndellingwood/spack that referenced this pull request Apr 8, 2025
Corresponds to the kokkos 4.6.00 release, see PRs:
* spack#49810
* trilinos/Trilinos#13925

Signed-off-by: Nathan Ellingwood <[email protected]>
alalazo pushed a commit that referenced this pull request Apr 14, 2025
Corresponds to the kokkos 4.6.00 release, see PRs:
* #49810
* trilinos/Trilinos#13925

Signed-off-by: Nathan Ellingwood <[email protected]>
haampie pushed a commit to haampie/spack-packages that referenced this pull request Apr 14, 2025
Corresponds to the kokkos 4.6.00 release, see PRs:
* spack/spack#49810
* trilinos/Trilinos#13925

Signed-off-by: Nathan Ellingwood <[email protected]>
climbfuji pushed a commit to climbfuji/spack that referenced this pull request Apr 17, 2025
* kokkos: add version 4.6.00

* kokkos-kernels: add version 4.6.00

* kokkos-nvcc-wrapper: add version 4.6.00 and update url to match kokkos releases

* kokkos: add zen4 support
climbfuji pushed a commit to climbfuji/spack that referenced this pull request Apr 17, 2025
Corresponds to the kokkos 4.6.00 release, see PRs:
* spack#49810
* trilinos/Trilinos#13925

Signed-off-by: Nathan Ellingwood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants