-
Notifications
You must be signed in to change notification settings - Fork 2.4k
kokkos: add v4.6.00 #49810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kokkos: add v4.6.00 #49810
Conversation
595a671
to
e82aef2
Compare
@cedricchevalier19 just realized there might be a need to make the |
Can we also add a change below line 204:
See PR #7550 in Kokkos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about zen4
.
I do not think we want to expose it. For Cuda, it was blocking users with some MPI implementations, but tests have not shown this kind of issue for ROCm. |
@tldahlgren can you give us the missing approval? I don't want to approve my own PR ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Re]Confirmed all of the affected sha256s.
Corresponds to the kokkos 4.6.00 release, see PRs: * spack#49810 * trilinos/Trilinos#13925 Signed-off-by: Nathan Ellingwood <[email protected]>
Corresponds to the kokkos 4.6.00 release, see PRs: * #49810 * trilinos/Trilinos#13925 Signed-off-by: Nathan Ellingwood <[email protected]>
Corresponds to the kokkos 4.6.00 release, see PRs: * spack/spack#49810 * trilinos/Trilinos#13925 Signed-off-by: Nathan Ellingwood <[email protected]>
* kokkos: add version 4.6.00 * kokkos-kernels: add version 4.6.00 * kokkos-nvcc-wrapper: add version 4.6.00 and update url to match kokkos releases * kokkos: add zen4 support
Corresponds to the kokkos 4.6.00 release, see PRs: * spack#49810 * trilinos/Trilinos#13925 Signed-off-by: Nathan Ellingwood <[email protected]>
No description provided.