Favour's PR #2
Open
Favour's PR #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumiscript
commented
Jun 3, 2018
src/components/Cart/Cart.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| import React from "react"; | |||
| import ItemList from "../Item-list/Item-list"; | |||
| const cart = props => { | |||
There was a problem hiding this comment.
to support standards, name your components with a starting capital letter so we are able to differentiate between functions and components.
There was a problem hiding this comment.
refactor this to use map instead of for.. break the operation into 2 steps.. the first step should multiply each item price by its quantity and the second step will add up all the items in the array. this can be 2 separate functions chained together.
What i described above is functional programming 101
| }; | ||
|
|
||
| addToCart = (id) => { | ||
| const inventoryIndex = this.state.inventory.findIndex(p => { |
There was a problem hiding this comment.
you can refactor this operation to be a filter and you return the output of the filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge.. PR created for Code Review purposes