fix(docs): multiple close button shown on mobile sidenav header #574
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR4SAN
force-pushed
the
bugfix/mobile-header-close-button
branch
from
a442412 to
522df88
Compare
PR4SAN
force-pushed
the
bugfix/mobile-header-close-button
branch
from
522df88 to
f94dd3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This pr fix removes the close button from the header component as we already have another close button on the sheet component resulting in multiple close buttons on the header.
Closes #573
What is the new behavior?
Now only one close button is shown while opening the docs page on mobile device.
Does this PR introduce a breaking change?
Other information