Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flagged accept array. add FlaggedByEvery #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Flagged accept array. add FlaggedByEvery #35

wants to merge 1 commit into from

Conversation

samsaffre
Copy link

  • Update flaggedScope method for accept array or collection. Model must have at least one of the flags to be retrived.
  • Create flaggedByEveryScope only accept Collection or array Model must have every flags in list to be retrieved.
  • Create ensureValues for prepare flag names and ensure type is string or backendEnum

freekmurze
freekmurze requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add tests?

README.md
YourModel::flagged(['myFlag', 'yourFlag']);

// query all models that have every flags in the given list
YourModel::flaggedByevery(['myFlag', 'yourFlag']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the method to the more simple flaggedByAll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze freekmurze requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsaffre @freekmurze