Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow optional file name when creating job #7

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Allow optional file name when creating job #7

merged 3 commits into from
Sep 12, 2023

Conversation

mnemitz
Copy link
Contributor

@mnemitz mnemitz commented Sep 8, 2023 •
edited
Loading

This PR adds support for passing a fileName string when calling transcribe or createJob.

This is to handle the case where a user passes a raw Blob as opposed to a File. It will also be useful when we add support for Buffer or ReadStream inputs, which will also lack file name metadata.

@mnemitz mnemitz requested a review from anjz September 12, 2023 09:50
anjz
anjz approved these changes Sep 12, 2023
View reviewed changes
Copy link

@anjz anjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnemitz mnemitz merged commit a99bd76 into main Sep 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjz anjz anjz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnemitz @anjz