Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle premature websocket close #78

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

mnemitz
Copy link
Contributor

@mnemitz mnemitz commented Nov 1, 2024

  • Add logic ensuring if socket closes before the ConversationStarted message is received, we give up waiting for it
  • Add test
  • Add cancellable functionality to timeouts, so the test scripts don't hang on an orphaned promise
  • Add error type strings to the SpeechmaticsFlowError class, so we can handle different errors differently
  • Add the "ws" dependency to the flow-client package (this was missing before, breaking the Node polyfill)

@mnemitz mnemitz changed the title Flow start conversation immediate close Handle premature websocket close Nov 1, 2024
@mnemitz mnemitz merged commit 4448c63 into main Nov 1, 2024
3 checks passed
@BellaT BellaT deleted the flow-start-conversation-immediate-close branch November 1, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants