fix: propagate errors from CacheOnReadFs.Open#601
Open
leno23 wants to merge 1 commit into
Open
Conversation
Fixes spf13#116. Return errors from base and layer Open calls instead of ignoring the base error when opening unioned directories. Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
Owner
|
Thanks for these contributions. Before we can review and merge, you'll need to sign the Contributor License Agreement (CLA). Please do so and then let us know — we'll pick up the review from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #116.
CacheOnReadFs.Openno longer ignores errors frombase.Openwhen opening unioned directories. Both base and layer errors are returned to callers instead of constructing a potentially invalidUnionFile.Test plan
go test ./...