fix(mem): return EISDIR when reading from directory handles#610
Open
leno23 wants to merge 1 commit into
Open
Conversation
MemMapFs allowed ReadFile to succeed on directories because mem.File ReadAt did not reject directory handles. Align with os and other afero filesystems by returning a PathError wrapping syscall.EISDIR. Fixes spf13#201 Co-authored-by: Cursor <cursoragent@cursor.com>
|
wuyangfan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Owner
|
Thanks for these contributions. Before we can review and merge, you'll need to sign the Contributor License Agreement (CLA). Please do so and then let us know — we'll pick up the review from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #201
afero.ReadFileon a directory path withMemMapFspreviously returned empty data without error. The in-memory file handle allowedRead/ReadAton directory nodes.This change aligns
mem.Filewithtarfs,zipfs, andgcsfsby returning aPathErrorwrappingsyscall.EISDIRfor read, write, seek, and truncate operations on directories.Test plan
go test ./...TestReadFileDirectoryMemMapFs