Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e fix: restarting spiderpool-controller failed #3825

Closed
wants to merge 1 commit into from

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Aug 4, 2024

Thanks for contributing!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3806

Special notes for your reviewer:

@ty-dc ty-dc added release/none no release note cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. labels Aug 4, 2024
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (1138e66) to head (8d03168).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3825      +/-   ##
==========================================
- Coverage   81.68%   81.16%   -0.53%     
==========================================
  Files          50       50              
  Lines        4391     4391              
==========================================
- Hits         3587     3564      -23     
- Misses        643      670      +27     
+ Partials      161      157       -4     
Flag Coverage Δ
unittests 81.16% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ty-dc ty-dc closed this Aug 4, 2024
@ty-dc ty-dc reopened this Aug 4, 2024
@ty-dc ty-dc force-pushed the fix/3806 branch 4 times, most recently from a9fa0f4 to 0720674 Compare August 4, 2024 14:18
@ty-dc ty-dc added the pr/not-ready not ready for merging label Aug 4, 2024
@ty-dc
Copy link
Collaborator Author

ty-dc commented Aug 13, 2024

/close

@ty-dc ty-dc closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. pr/not-ready not ready for merging release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: the spiderpool controller failed to restart
1 participant