Fixes to compile and run on Windows #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation on GOOS=windows for the main binary and tests, both of which were broken. Fix a leaked open file handle which caused config_test.go to fail on windows with "Sharing violation" errors when cleaning up the tempdir. Add a 'test-wine' Makefile target. Explain how to run the tests for windows via wine in the readme. Signed-off-by: Craig Ringer <[email protected]>
ringerc
added a commit
to ringerc/spiffe-helper-PRs
that referenced
this pull request
Feb 5, 2025
… into retry-signal-pid-file These are tracked by PRs * spiffe#258 for test suite * spiffe#257 for windows Once they are merged the upcoming commit can be merged in its own PR
faisal-memon
reviewed
Feb 7, 2025
| @@ -7,6 +7,9 @@ rpm/*.rpm | |||
| *.swp | |||
| *.swo | |||
| bootstrap.crt | |||
| # for 'go test -c ./...' output | |||
There was a problem hiding this comment.
Suggested change
| # for 'go test -c ./...' output | |
| # for 'go test -c ./...' output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation on GOOS=windows for the main binary and tests, both of which were broken.
Fix a leaked open file handle which caused config_test.go to fail on windows with "Sharing violation" errors when cleaning up the tempdir.
Add a 'test-wine' Makefile target. Explain how to run the tests for windows via wine in the readme.
Split from #252