Skip to content

Conversation

@itowlson
Copy link
Collaborator

This aligns the Spin 3.5 WITs with what we actually support. This is to address an issue where compilers (e.g. Rust with the wasm32-wasip2 target) may emit up-level imports that run fine on Spin but fail target world validation. The risk of regressions seems low because 1. backward compatible and 2. Spin never actually uses these WITs, it just provides whatever the wasi crate gives it. This is more about a correct reference that we can publish for validation and/or use for SDKs etc.

We should figure out whether to retcon the Spin 3.4 WITs too.

Draft for feedback and discussion (and integration testing!).

Signed-off-by: itowlson <[email protected]>
@fibonacci1729
Copy link
Collaborator

I think it would make sense to do this for whatever target envs we have published.

@fibonacci1729
Copy link
Collaborator

For current published envs we have remaining:

v3.2.0 -> [email protected] (wasmtime 29.0.1)
v3.4.0 -> [email protected] (wasmtime 36.0.1)

Good news is that updating v3.4.0 should be a step easier because we already include [email protected] in this PR. I'll take a tab at PRing for v3.2.0

@@ -1,6 +1,11 @@
package wasi:clocks@0.2.0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can we name this folder wit/deps/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants