New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/InsightMenu): Removes code that throws error in the console #9001

Open

bbrina wants to merge 4 commits into spinnaker:master from bbrina:fix-insight-menu-console-error

Contributor

bbrina commented Mar 17, 2021

What does this PR do?

Removes href="javascript:void(0)" from Button component.

Some of the benefits:

Component renders as <button> instead of <a>
Fixes the following error:

bbrina added 3 commits

March 17, 2021 15:40


          fix(core/InsightMenu): Removes code that throws error in the console

dd75ee6


          fix(core/InsightMenu): Fixes functional test

2ec7598


          fix(core/InsightMenu): Fix for functional test

c40ff19

bbrina force-pushed the fix-insight-menu-console-error branch from 423800d to c40ff19 Compare

March 18, 2021 18:14


          Merge branch 'master' into fix-insight-menu-console-error

058347b

dogonthehorizon approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet