Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Wercker): Removed Wercker reference as Wercker has been deprecated #1214

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
@Slf4j
public class BuildEventHandler extends BaseTriggerEventHandler<BuildEvent> {
private static final String[] BUILD_TRIGGER_TYPES = {
"jenkins", "travis", "wercker", "concourse", "gitlab-ci"
"jenkins", "travis", "concourse", "gitlab-ci"
};
private static final List<String> supportedTriggerTypes =
Collections.unmodifiableList(Arrays.asList(BUILD_TRIGGER_TYPES));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ class BuildEventHandlerSpec extends Specification implements RetrofitStubs {
event | trigger | triggerType
createBuildEventWith(SUCCESS) | enabledJenkinsTrigger | 'jenkins'
createBuildEventWith(SUCCESS) | enabledTravisTrigger | 'travis'
createBuildEventWith(SUCCESS) | enabledWerckerTrigger | 'wercker'
}

@Unroll
Expand All @@ -87,7 +86,6 @@ class BuildEventHandlerSpec extends Specification implements RetrofitStubs {
event | pipeline | triggerType | expectedTrigger
createBuildEventWith(SUCCESS) | createPipelineWith(enabledJenkinsTrigger, nonJenkinsTrigger) | 'jenkins' | enabledJenkinsTrigger
createBuildEventWith(SUCCESS) | createPipelineWith(enabledTravisTrigger, nonJenkinsTrigger) | 'travis' | enabledTravisTrigger
createBuildEventWith(SUCCESS) | createPipelineWith(enabledWerckerTrigger, nonJenkinsTrigger) | 'wercker' | enabledWerckerTrigger
createBuildEventWith(SUCCESS) | createPipelineWith(enabledConcourseTrigger, nonJenkinsTrigger) | 'concourse' | enabledConcourseTrigger
}

Expand Down Expand Up @@ -190,7 +188,6 @@ class BuildEventHandlerSpec extends Specification implements RetrofitStubs {
trigger | description
disabledJenkinsTrigger | "disabled jenkins"
disabledTravisTrigger | "disabled travis"
disabledWerckerTrigger | "disabled wercker"
disabledConcourseTrigger | "disabled concourse"
nonJenkinsTrigger | "non-Jenkins"
enabledStashTrigger | "stash"
Expand Down Expand Up @@ -220,8 +217,6 @@ class BuildEventHandlerSpec extends Specification implements RetrofitStubs {
enabledJenkinsTrigger.withJob(null) | "job" | "jenkins"
enabledTravisTrigger.withMaster(null) | "master" | "travis"
enabledTravisTrigger.withJob(null) | "job" | "travis"
enabledWerckerTrigger.withMaster(null) | "master" | "wercker"
enabledWerckerTrigger.withJob(null) | "job" | "wercker"

event = createBuildEventWith(SUCCESS)
goodPipeline = createPipelineWith(enabledJenkinsTrigger)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ trait RetrofitStubs {
final Trigger enabledJenkinsTriggerWithRunAsUser = enabledJenkinsTrigger.withRunAsUser("user@managed-service-account")
final Trigger enabledTravisTrigger = Trigger.builder().enabled(true).type('travis').master('master').job('job').build()
final Trigger disabledTravisTrigger = Trigger.builder().enabled(false).type('travis').master('master').job('job').build()
final Trigger enabledWerckerTrigger = Trigger.builder().enabled(true).type('wercker').master('master').job('job').build()
final Trigger disabledWerckerTrigger = Trigger.builder().enabled(false).type('wercker').master('master').job('job').build()
final Trigger enabledConcourseTrigger = Trigger.builder().enabled(true).type('concourse').master('master').job('job').build()
final Trigger disabledConcourseTrigger = Trigger.builder().enabled(false).type('concourse').master('master').job('job').build()
final Trigger nonJenkinsTrigger = Trigger.builder().enabled(true).type('not jenkins').master('master').job('job').build()
Expand Down