Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications/cdEvents): added support for customData #1424

Merged
merged 5 commits into from
Jul 11, 2024
Merged

feat(notifications/cdEvents): added support for customData #1424

merged 5 commits into from
Jul 11, 2024

Conversation

tonyg4864
Copy link
Contributor

@tonyg4864 tonyg4864 commented Jun 10, 2024 •
edited
Loading

  • Added support for CDEvents customData so that pipelines can add additional custom data to the event notification.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 221b05e: Added support for cdEvents customData

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@rjalander
Copy link
Contributor

rjalander commented Jun 11, 2024 •
edited
Loading

@tonyg4864 thanks for creating this PR,
This can be fixed by upgrading CDEvents Java SDK to `cdevents-sdk-java:0.3.1’ for now. And just to inform we are also working on release cdevents Java SDK 0.4.1, with more fixes and updated spec and we can also plan to update Spinnaker with this latest version soon.

@tonyg4864
Copy link
Contributor Author

@rjalander That's awesome. Looking forward to it. Any problems you see if we move forward with this PR for the meanwhile ?

rjalander
rjalander reviewed Jun 11, 2024
View reviewed changes
...src/test/groovy/com/netflix/spinnaker/echo/notification/CDEventsNotificationAgentSpec.groovy
"dev.cdevents.pipelinerun.started" || /dev.cdevents.pipelinerun.started.0.1.1/ || /started/
"dev.cdevents.pipelinerun.finished" || /dev.cdevents.pipelinerun.finished.0.1.1/ || /complete/
"dev.cdevents.taskrun.started" || /dev.cdevents.taskrun.started.0.1.1/ || /started/
"dev.cdevents.taskrun.finished" || /dev.cdevents.taskrun.finished.0.1.1/ || /complete/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, if you can add validation for expected customData too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjalander Added validation for expected customData .

@tonyg4864 tonyg4864 changed the title Added support for cdEvents customData feat(notifications/cdEvents): added support for customData Jul 5, 2024
link108
link108 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@link108 link108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@link108 link108 merged commit 01ada0c into spinnaker:master Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@link108 link108 link108 approved these changes

@rjalander rjalander rjalander approved these changes

Assignees
No one assigned
Labels
target-release/1.35
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonyg4864 @spinnakerbot @rjalander @link108