Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): More configurable readiness/liveness probes #1598

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jcavanagh
Copy link
Contributor

Adds additional configuration options for liveness, and adds the same options for readiness.
Probes have the same basic options, so refactored the type to be shared for both.

Example halconfig block:

deploymentEnvironment:
  # Numbers arbitrary
  livenessProbeConfig:
    enabled: true
    initialDelaySeconds: 9001
    timeoutSeconds: 62
    periodSeconds: 60
    successThreshold: 1
    failureThreshold: 5
  readinessProbeConfig:
    enabled: true
    initialDelaySeconds: 9001
    timeoutSeconds: 64
    periodSeconds: 61
    successThreshold: 2
    failureThreshold: 4

jcavanagh and others added 2 commits March 27, 2020 13:19
Adds additional configuration options for liveness, and adds the same options for readiness.
Probes have the same basic options, so refactored the type to be shared for both.

Example halconfig block:

```
deploymentEnvironment:
  # Numbers arbitrary
  livenessProbeConfig:
    enabled: true
    initialDelaySeconds: 9001
    timeoutSeconds: 62
    periodSeconds: 60
    successThreshold: 1
    failureThreshold: 5
  readinessProbeConfig:
    enabled: true
    initialDelaySeconds: 9001
    timeoutSeconds: 64
    periodSeconds: 61
    successThreshold: 2
    failureThreshold: 4
```
@maggieneterval maggieneterval self-requested a review August 3, 2020 15:05
@maggieneterval
Copy link
Contributor

@jcavanagh apologies for the delayed response to this PR. We are actually planning on sunsetting Halyard in favor of a Kustomize-based installation path that will make it much easier to make modifications like custom readiness and liveness probes without an upstream pull request. That said, I am happy to review and merge this PR: if you are still interested in getting this merged, would you mind resolving the merge conflicts? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants