feat(provider/google): Added all cloudrun commands in halyard #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a video of all the halyard cloudrun commands. It is working as expected. Pls let me know if you have any more issues.. cloudrun-cmds.mp4 |
Listed out all commands in the PR description. Pls can you check once? |
| static final String LOCAL_REPOSITORY_DIRECTORY_DESCRIPTION = | ||
| "A local directory to be used to stage source files" | ||
| + " for Cloud Run deployments within Spinnaker's Clouddriver microservice."; | ||
| static final String GIT_HTTPS_USERNAME_DESCRIPTION = |
There was a problem hiding this comment.
Is it useful to cloudrun? What is the usecase with GIT?
There was a problem hiding this comment.
It is not useful for cloudrun. we need to remove.
There was a problem hiding this comment.
@kirangodishala Can you review once now?
kirangodishala
approved these changes
Sep 17, 2024
kirangodishala
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of spinnaker/governance#302
Added all cloudrun commands in halyard.
halyard cloudrun commands:
hal config provider appengine [parameters] [subcommands]
account: Manage and view Spinnaker configuration for the cloudrun provider’s account
disable: Set the cloudrun provider as disabled
edit: Edit cloudrun’s app engine configuration.
enable: Set the cloudrun provider as enabled
hal config provider cloudrun account ACCOUNT [parameters] [subcommands]
add: Add an account to the cloudrun provider.
delete: Delete a specific cloudrun account by name.
edit: Edit an account in the cloudrun provider.
get: Get the specified account details for the cloudrun provider.
list: List the account names for the cloudrun provider.
hal config provider cloudrun account delete ACCOUNT [parameters]
ACCOUNT: The name of the account to operate on.
hal config provider cloudrun account get ACCOUNT [parameters]
ACCOUNT: The name of the account to operate on.
hal config provider cloudrun disable [parameters]
hal config provider cloudrun account list [parameters]
hal config provider cloudrun enable [parameters]
Parameters
--deployment: If supplied, use this Halyard deployment. This will not create a new deployment.
--no-validate: (Default: false) Skip validation.