vortex: Basic Variant IO support#25
Open
AdamGS wants to merge 7 commits into
Open
Conversation
bee87b4 to
a735a4d
Compare
robert3005
reviewed
Jun 9, 2026
|
|
||
| @Override | ||
| public VortexValueReader<?> primitive(Type.PrimitiveType iPrimitive, Field primField) { | ||
| if (VortexSchemas.isVariantField(primField)) { |
Member
There was a problem hiding this comment.
Variant is not a primitive? I think you need to add a new top level method to VortexValueReader VortexRowReader
Author
There was a problem hiding this comment.
no idea how or why it got there, I'll fix it.
Author
There was a problem hiding this comment.
I think the fix is in the visitor? LMK what you think.
Member
|
you also have this failure |
Author
|
I think the failure is fixed in upstream Voretx. |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
ecf2a25 to
feb347b
Compare
Author
|
ok now there's some spark stuff I need to fix, will get to it later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic support for variant in Vortex through the generic record-based writer.
Depends on:
Work that is still missing here: