Serialize properties in impression#754
Merged
gthea merged 4 commits intoSDKS-9648_baselinefrom Apr 25, 2025
Merged
Conversation
gthea
force-pushed
the
SDKS-9648_baseline
branch
from
8b367f8 to
6e5ad13
Compare
sanzmauro
reviewed
Apr 25, 2025
| public void enableTracking(boolean enable) { | ||
| isTrackingEnabled.set(enable); | ||
| } | ||
|
|
Comment on lines
+128
to
+131
| long start = System.currentTimeMillis(); | ||
| while (!mScheduledTasks.isEmpty() && (System.currentTimeMillis() - start) < 500L) { | ||
| try { Thread.sleep(50); } catch (InterruptedException e) { break; } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
When the app goes to background we pause the task executor and sometimes tasks could end up not completing. This adds a small grace period to give them a chance to finish.
| public class SplitTaskExecutorImpl extends SplitBaseTaskExecutor { | ||
|
|
||
| private static final int MIN_THREAD_POOL_SIZE_WHEN_IDLE = 2; | ||
| private static final int MIN_THREAD_POOL_SIZE_WHEN_IDLE = 6; |
Contributor
Author
There was a problem hiding this comment.
This was originally 6, it was reduced to 2 in the last rc but I'm restoring it.
|
|
||
| @Override | ||
| public Result validate(Map<String, Object> properties) { | ||
| return Result.valid(properties, 0); // TODO implement |
Contributor
There was a problem hiding this comment.
why is missing this implementation?
Comment on lines
-14
to
-31
| String getTreatment(String split, Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| SplitResult getTreatmentWithConfig(String split, Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| Map<String, String> getTreatments(List<String> splits, Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| Map<String, SplitResult> getTreatmentsWithConfig(List<String> splits, Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| Map<String, String> getTreatmentsByFlagSet(@NonNull String flagSet, @Nullable Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| Map<String, String> getTreatmentsByFlagSets(@NonNull List<String> flagSets, @Nullable Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| Map<String, SplitResult> getTreatmentsWithConfigByFlagSet(@NonNull String flagSet, @Nullable Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
| Map<String, SplitResult> getTreatmentsWithConfigByFlagSets(@NonNull List<String> flagSets, @Nullable Map<String, Object> attributes, boolean isClientDestroyed); | ||
|
|
||
|
|
||
| // temporary methods to reduce changes in this iteration |
Contributor
There was a problem hiding this comment.
why are you removing all this methods?
Contributor
Author
There was a problem hiding this comment.
I added new ones. This is internal, no changes to the API.
sanzmauro
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android SDK
What did you accomplish?
TreatmentManagerImpl.