Conversation
sanzmauro
reviewed
Apr 25, 2025
Comment on lines
30
to
33
| final String properties = impression.properties(); | ||
| if (properties != null && !properties.isEmpty()) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
why are you adding this here and not in the strategy?
In my opinion, the impressionObserver is not responsible for checking whether the impression has properties or not.
Contributor
Author
There was a problem hiding this comment.
Hmm I didn't consider that, doing it here means I only make the change in one instead of two places.
But it's true that we were going to do it in the strategies, so I'll change it.
sanzmauro
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android SDK
What did you accomplish?