Skip to content

RBS feature #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gthea merged 26 commits into from
May 20, 2025
Merged

RBS feature #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
de25998
Update development branch (#737)
gthea Feb 20, 2025
b6bd98a
New DTOs & POJOs (#738)
gthea Feb 24, 2025
67995a1
RBS in memory storage (#739)
gthea Feb 25, 2025
84afe71
DB changes for RBS (#740)
gthea Feb 25, 2025
df61923
SqLite persistent storage implementation for RBS (#741)
gthea Feb 26, 2025
e6ad338
RBS Storage provider (#742)
gthea Feb 27, 2025
2a7a3dd
RBS matcher (#743)
gthea Feb 28, 2025
9327053
RBS parser (#744)
gthea Feb 28, 2025
0c12752
Update splitChanges response (#745)
gthea Mar 6, 2025
22204ed
SyncHelper with RBS storage (#746)
gthea Mar 7, 2025
d82d358
Add RBS change number as query param (#747)
gthea Mar 10, 2025
177e7e1
Process RBS streaming notification (#748)
gthea Mar 13, 2025
d6dd3d4
Add missing tests (#749)
gthea Mar 13, 2025
e5b1426
Encryption mode migration of RBS storage (#750)
gthea Mar 13, 2025
1a19cf7
Instrumented tests for RBS (#751)
gthea Mar 14, 2025
5960735
Update spec
gthea Mar 19, 2025
0f6a3db
Update tests
gthea Mar 19, 2025
2e8c186
Handle legacy SplitChange DTO (#761)
gthea May 12, 2025
aa1792a
Added support for multiple excluded segment types (#762)
gthea May 12, 2025
f15edcd
Fixes to encryption migration for RBS (#763)
gthea May 12, 2025
bc396f6
Outdated proxy handling (#764)
gthea May 12, 2025
d438c4c
Remove usage of Gson internal method
gthea May 12, 2025
69181c2
Fix tests
gthea May 12, 2025
f9f070e
Update version
gthea May 20, 2025
aeec0ef
Ubuntu latest
gthea May 20, 2025
73c8237
Update API level
gthea May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/instrumented.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ concurrency:

jobs:
test:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
api-level: [ 29 ]
api-level: [ 28 ]
shard: [ 0, 1, 2, 3 ]

steps:
Expand Down Expand Up @@ -53,7 +53,6 @@ jobs:
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ matrix.api-level }}
avd-name: macOS-avd-arm64-v8a-29
force-avd-creation: false
emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: true
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ apply plugin: 'kotlin-android'
apply from: 'spec.gradle'

ext {
splitVersion = '5.2.0'
splitVersion = '5.3.0-rc1'
}

android {
Expand Down
2 changes: 1 addition & 1 deletion spec.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ext {

// flags spec contains a String with the feature flags specification
flagsSpec = '1.2'
flagsSpec = '1.3'
}
335 changes: 170 additions & 165 deletions src/androidTest/assets/attributes_test_split_change.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,182 +1,187 @@
{
"splits":[
"ff": {
"splits": [
{
"trafficTypeName":"client",
"name":"workm",
"trafficAllocation":100,
"trafficAllocationSeed":147392224,
"seed":524417105,
"status":"ACTIVE",
"killed":false,
"defaultTreatment":"on",
"changeNumber":1602796638344,
"algo":2,
"configurations":{

},
"conditions":[
{
"conditionType":"ROLLOUT",
"matcherGroup":{
"combiner":"AND",
"matchers":[
{
"keySelector":{
"trafficType":"client",
"attribute":"num_value"
},
"matcherType":"EQUAL_TO",
"negate":false,
"userDefinedSegmentMatcherData":null,
"whitelistMatcherData":null,
"unaryNumericMatcherData":{
"dataType":"NUMBER",
"value":10
},
"betweenMatcherData":null,
"booleanMatcherData":null,
"dependencyMatcherData":null,
"stringMatcherData":null
}
]
},
"partitions":[
{
"treatment":"on_num_10",
"size":100
"trafficTypeName": "client",
"name": "workm",
"trafficAllocation": 100,
"trafficAllocationSeed": 147392224,
"seed": 524417105,
"status": "ACTIVE",
"killed": false,
"defaultTreatment": "on",
"changeNumber": 1602796638344,
"algo": 2,
"configurations": {
},
"conditions": [
{
"conditionType": "ROLLOUT",
"matcherGroup": {
"combiner": "AND",
"matchers": [
{
"keySelector": {
"trafficType": "client",
"attribute": "num_value"
},
{
"treatment":"off",
"size":0
}
],
"label":"rule 1"
}
]
},
{
"conditionType":"ROLLOUT",
"matcherGroup":{
"combiner":"AND",
"matchers":[
{
"keySelector":{
"trafficType":"client",
"attribute":"str_value"
"matcherType": "EQUAL_TO",
"negate": false,
"userDefinedSegmentMatcherData": null,
"whitelistMatcherData": null,
"unaryNumericMatcherData": {
"dataType": "NUMBER",
"value": 10
},
"matcherType":"MATCHES_STRING",
"negate":false,
"userDefinedSegmentMatcherData":null,
"whitelistMatcherData":null,
"unaryNumericMatcherData":null,
"betweenMatcherData":null,
"booleanMatcherData":null,
"dependencyMatcherData":null,
"stringMatcherData":"yes"
}
]
},
"partitions":[
{
"treatment":"on_str_yes",
"size":100
"betweenMatcherData": null,
"booleanMatcherData": null,
"dependencyMatcherData": null,
"stringMatcherData": null
}
]
},
{
"treatment":"off",
"size":0
}
],
"label":"rule 2"
"partitions": [
{
"treatment": "on_num_10",
"size": 100
},
{
"treatment": "off",
"size": 0
}
],
"label": "rule 1"
}
]
},
{
"trafficTypeName":"client",
"name":"workm1",
"trafficAllocation":100,
"trafficAllocationSeed":147392224,
"seed":524417105,
"status":"ACTIVE",
"killed":false,
"defaultTreatment":"on",
"changeNumber":1602796638344,
"algo":2,
"configurations":{

},
"conditions":[
"conditionType": "ROLLOUT",
"matcherGroup": {
"combiner": "AND",
"matchers": [
{
"conditionType":"ROLLOUT",
"matcherGroup":{
"combiner":"AND",
"matchers":[
{
"keySelector":{
"trafficType":"client",
"attribute":"num_value_a"
},
"matcherType":"EQUAL_TO",
"negate":false,
"userDefinedSegmentMatcherData":null,
"whitelistMatcherData":null,
"unaryNumericMatcherData":{
"dataType":"NUMBER",
"value":20
},
"betweenMatcherData":null,
"booleanMatcherData":null,
"dependencyMatcherData":null,
"stringMatcherData":null
}
]
},
"partitions":[
{
"treatment":"on_num_20",
"size":100
},
{
"treatment":"off",
"size":0
}
],
"label":"rule 3"
"keySelector": {
"trafficType": "client",
"attribute": "str_value"
},
"matcherType": "MATCHES_STRING",
"negate": false,
"userDefinedSegmentMatcherData": null,
"whitelistMatcherData": null,
"unaryNumericMatcherData": null,
"betweenMatcherData": null,
"booleanMatcherData": null,
"dependencyMatcherData": null,
"stringMatcherData": "yes"
}
]
]
},
"partitions": [
{
"treatment": "on_str_yes",
"size": 100
},
{
"treatment": "off",
"size": 0
}
],
"label": "rule 2"
},
{
"conditionType":"ROLLOUT",
"matcherGroup":{
"combiner":"AND",
"matchers":[
{
"keySelector":{
"trafficType":"client",
"attribute":"str_value_a"
"trafficTypeName": "client",
"name": "workm1",
"trafficAllocation": 100,
"trafficAllocationSeed": 147392224,
"seed": 524417105,
"status": "ACTIVE",
"killed": false,
"defaultTreatment": "on",
"changeNumber": 1602796638344,
"algo": 2,
"configurations": {
},
"conditions": [
{
"conditionType": "ROLLOUT",
"matcherGroup": {
"combiner": "AND",
"matchers": [
{
"keySelector": {
"trafficType": "client",
"attribute": "num_value_a"
},
"matcherType":"MATCHES_STRING",
"negate":false,
"userDefinedSegmentMatcherData":null,
"whitelistMatcherData":null,
"unaryNumericMatcherData":null,
"betweenMatcherData":null,
"booleanMatcherData":null,
"dependencyMatcherData":null,
"stringMatcherData":"no"
}
]
},
"partitions":[
{
"treatment":"on_str_no",
"size":100
"matcherType": "EQUAL_TO",
"negate": false,
"userDefinedSegmentMatcherData": null,
"whitelistMatcherData": null,
"unaryNumericMatcherData": {
"dataType": "NUMBER",
"value": 20
},
"betweenMatcherData": null,
"booleanMatcherData": null,
"dependencyMatcherData": null,
"stringMatcherData": null
}
]
},
"partitions": [
{
"treatment": "on_num_20",
"size": 100
},
{
"treatment": "off",
"size": 0
}
],
"label": "rule 3"
}
]
},
{
"conditionType": "ROLLOUT",
"matcherGroup": {
"combiner": "AND",
"matchers": [
{
"treatment":"off",
"size":0
"keySelector": {
"trafficType": "client",
"attribute": "str_value_a"
},
"matcherType": "MATCHES_STRING",
"negate": false,
"userDefinedSegmentMatcherData": null,
"whitelistMatcherData": null,
"unaryNumericMatcherData": null,
"betweenMatcherData": null,
"booleanMatcherData": null,
"dependencyMatcherData": null,
"stringMatcherData": "no"
}
],
"label":"rule 3"
]
},
"partitions": [
{
"treatment": "on_str_no",
"size": 100
},
{
"treatment": "off",
"size": 0
}
],
"label": "rule 3"
}
],
"since":1602796638344,
"till":1602796638344
],
"since": 1602796638344,
"till": 1602796638344
},
"rbs": {
"d": [],
"s": 1602796638341,
"t": 1602796638341
}
}
Loading
Loading