Merged
Conversation
|
SonarQube Quality Gate
|
chillaq
reviewed
Aug 22, 2025
| return false; | ||
| } | ||
| return flagName.length() <= MAX_FLAG_NAME_LENGTH && !flagName.contains(" "); | ||
| } |
There was a problem hiding this comment.
I think we need to match the UI for ff and treatment names, here is the message I see in UI:
Please rename your split. Split names must start with a letter and can contain "-_ a-z A-Z 0-9"
Contributor
Author
There was a problem hiding this comment.
Sounds good. I'll have to double check how these values impact posted impressions.
There was a problem hiding this comment.
We can use this regex:
^[a-zA-Z][a-zA-Z0-9-_$;]+$
Contributor
Author
There was a problem hiding this comment.
TBD, we'll tighten the definition in the coming days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android SDK
What did you accomplish?