pull request: bug fixes, improvements, french translation#7
Open
yogoo wants to merge 8 commits intosplittingred:developfrom
Open
pull request: bug fixes, improvements, french translation#7yogoo wants to merge 8 commits intosplittingred:developfrom
yogoo wants to merge 8 commits intosplittingred:developfrom
Conversation
New: crumb separator is templateable via chunk 'bcTplCrumbSeparator' Fix: pass html5 validation (move crumb separator inside <li> + remove invalid rel attributes in <a>)
|
Got a testing branch for this here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Shaun,
Here's a batch of fixes and updates for Breadcrumbs.
0#6] extra li tag around last item when currentAsLink=0.Tested with modx 2.2.0-pl2 and 2.2.1-dev (march 15, 2012)
Let me know if you're too busy with modx development to publish a transport package and update the doc. I can help with that if you want to.
Jerome