Module settings PoC #148
Open
Module settings PoC #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // @cb_ {function(err, module)} | ||
| // ``` | ||
| settings_get = function(path, cb_) { | ||
| my.core_module.procedures.settings_get(path, null, function(err, settings) { |
There was a problem hiding this comment.
@spolu This is a bit fishy... From the module_manager is there a more straightforward way to call methods on the core_store object?
|
That's great! I should be able to put some cycle in it today! |
|
@spolu Signing off for tonight, but I agree we should definitely have a consistent UI. Let me know how it goes! |
|
OK! Awesome stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spolu So, here's where I am – ACE inside Breach looks pretty neat!
The main hurdle I've had is with
core_store: so far I haven't gotten how it works (!), so I've mocked it up with an in-memory store – let me know how you'd do it. It could be useful to expose a simpler, non-distributed data-store for the time being?Let me know what you think