Add support of UUID values when encoding avro #971
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnapz
changed the title
shnapz
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
============================================
- Coverage 91.67% 91.39% -0.28%
Complexity 253 253
============================================
Files 26 26
Lines 949 953 +4
Branches 71 72 +1
============================================
+ Hits 870 871 +1
- Misses 52 54 +2
- Partials 27 28 +1 🚀 New features to boost your workflow:
|
| @@ -27,7 +27,8 @@ SELECT | |||
| random() * (timestamp '2010-01-01 00:00:00' - | |||
| timestamp '2020-01-01 00:00:00') AS timestamp2, | |||
| E'\\000'::bytea AS bytes_field, | |||
| ARRAY['foo', 'bar']::text[] AS arr1 | |||
| ARRAY['foo', 'bar']::text[] AS arr1, | |||
| ARRAY[gen_random_uuid(), gen_random_uuid()]::uuid[] AS arr2 | |||
There was a problem hiding this comment.
I assume the test(s) failed because of this addition, before the actual fix in the code
farzad-sedghi
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for PR author(s)
mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)